fix(release): backport YAML duplicate env fix into main#336
Merged
Conversation
…ml (#335) PR #330 在 jobs.build 顶层多加了一个 env: 块来定义 OPENLESS_RELEASE_CHANNEL, 但下面 strategy/runs-on 之后已经有一个 env: 块(TAURI_SIGNING_PRIVATE_KEY 等)。 YAML map 不允许重复 key——GitHub Actions 解析直接 fail,整条 release-tauri.yml 工作流变成 "workflow file issue" 启动失败。 修复:把 OPENLESS_RELEASE_CHANNEL 并到下面那个唯一的 env: 块里,保留完整注释。 校验: - python -c "yaml.safe_load(...)" 解析成功 - jobs.build.env 现在有 3 个 key: OPENLESS_RELEASE_CHANNEL, TAURI_SIGNING_PRIVATE_KEY, TAURI_SIGNING_PRIVATE_KEY_PASSWORD Co-authored-by: baiqing <lbx12309@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #335 已经把这个 `release-tauri.yml` 的 YAML `jobs.build.env` duplicate-key 启动失败 bug 在 `beta` 上修了。但 `main` 上这份文件没动——下次从 main 打 `v-tauri` stable tag 会重踩同样的坑(CI 在 "workflow file issue" 阶段直接 fail)。
这个 PR 是把 #335 的同 patch cherry-pick 到 main,保持 main 的 release pipeline 也是干净的。
What
cherry-pick `2246d8f6`(#335 squash commit),单文件 `-8/+7`:把 PR-B-1 在 `jobs.build` 顶层多加的 `OPENLESS_RELEASE_CHANNEL` 那个 `env:` 块并入下方原有的 `TAURI_SIGNING_PRIVATE_KEY` 那个 `env:` 块。
为什么不全量 sync beta → main
beta 还有一个 `chore: bump version to 1.2.24-beta.1 (#334)` commit——那是 Beta 渠道的故意版本号分叉,不应该进 main(main 应保持 stable 版本号 1.2.23 直到下次 stable cut)。所以本 PR 只 cherry-pick CI 修复一项。
Test plan